(fix) Add missing type annotation for missedAppointmentsCount#2287
Merged
denniskigen merged 1 commit intoopenmrs:mainfrom Mar 2, 2026
Merged
(fix) Add missing type annotation for missedAppointmentsCount#2287denniskigen merged 1 commit intoopenmrs:mainfrom
denniskigen merged 1 commit intoopenmrs:mainfrom
Conversation
Contributor
Author
|
@jayasanka-sack @ibacher @denniskigen please have a look at this! |
Member
|
The `missedAppointmentsCount` property in the `AppointmentCountMap` interface lacked a type annotation, defaulting to implicit `any`. This adds the correct `number` type to match the backend's `Integer` in both the appointments and service queues packages.
denniskigen
changed the title
denniskigen
force-pushed
the
fix/appointments-type-error
branch
from
f331b6a to
26147a7
Compare
denniskigen
approved these changes
Mar 2, 2026
Member
|
Thanks, @pggdev! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR improves type safety in the appointments module by replacing an incorrect
anytype with a more specific and appropriate type.The change resolves a TypeScript type error and ensures stronger compile-time validation without affecting runtime behavior.
No functional or UI changes were introduced.
Screenshots
N/A – No UI changes.
Related Issue
https://openmrs.atlassian.net/browse/O3-5451
Other
This is a small internal improvement focused on maintaining type correctness and improving overall code quality.